From dev-return-4844-apmail-plc4x-dev-archive=plc4x.apache.org@plc4x.apache.org Mon Oct 12 12:08:08 2020 Return-Path: X-Original-To: apmail-plc4x-dev-archive@locus.apache.org Delivered-To: apmail-plc4x-dev-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 5982C1960C for ; Mon, 12 Oct 2020 12:08:08 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 0BEC51224A3 for ; Mon, 12 Oct 2020 12:08:08 +0000 (UTC) Received: (qmail 33259 invoked by uid 500); 12 Oct 2020 12:01:28 -0000 Delivered-To: apmail-plc4x-dev-archive@plc4x.apache.org Received: (qmail 33228 invoked by uid 500); 12 Oct 2020 12:01:27 -0000 Mailing-List: contact dev-help@plc4x.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@plc4x.apache.org Delivered-To: mailing list dev@plc4x.apache.org Received: (qmail 33216 invoked by uid 99); 12 Oct 2020 12:01:27 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Oct 2020 12:01:27 +0000 From: =?utf-8?q?GitBox?= To: dev@plc4x.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bplc4x=5D_hutcheb_commented_on_pull_request_=23194?= =?utf-8?q?=3A_Add_an_OPC_UA_Server?= Message-ID: <160250408768.32230.14471110509323513328.asfpy@gitbox.apache.org> Date: Mon, 12 Oct 2020 12:01:27 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: hutcheb commented on pull request #194: URL: https://github.com/apache/plc4x/pull/194#issuecomment-707077234 It is definitely usable but somethings to improve on:- - Security isn't implemented. - Arrays should probably be a list of nodes in OPCUA instead of a single one. - Discovery doesn't seem to work. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org