poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 51803] Content on master slide is not extracted
Date Mon, 07 Nov 2011 17:41:06 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=51803

--- Comment #6 from mikemccand <lucene@mikemccandless.com> 2011-11-07 17:41:06 UTC ---
Created attachment 27907
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27907
Patch w/ fix, plus test

OK the change works well!  I see no more placeholder text from the
master slide.

I worked out a patch (attached), containing the above fix, and fixes
to the tests, and some minor improvements to Sheet.java (cutover from
Vector -> List<TextRun>).

One test failed with this change (TestExtracter.testMasterText),
because the master text in the test PPT for that test was in fact
placeholder text.

So, I replaced that test file (test-data/slideshow/master_text.ppt)
with a new PPT, that has non-placeholder text from the master slide,
and also added an assert to verify placeholder text doesn't come
through.

The assert fails on trunk today and passes with the patch, so I think
we are good.

Thanks Yegor!

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message