poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gettman, Randy" <RGett...@corelogic.com>
Subject Committing changes for Bug 51222 (which also solves Bugs 51236, 52079, and 53274)
Date Tue, 21 May 2013 22:26:18 GMT
Hello all,

Back in January 2013, I stumbled on bug 51222 when I was working with some of my own code
whose unit tests were failing (specifically, that the Unit Tests were reporting black when
it was white, and vice versa).

When I researched the Apache POI XSSFColor code, I was surprised to see comments in code saying
that Excel mixes up black and white, and I was surprised to see the "correctRGB" method. 
Initially, I wrote my code to ensure that "correctRGB" was called twice (via a second  call
to "getRGB" if necessary) to ensure that the colors were as reported.  But this caused errors
when colors were not themed.

After following the "theme" lead, I determined that Excel simply swaps black and white (also
tan and dark blue) entries in theme1.xml in an .xlsx document.  I submitted a patch for Bug
51222 back in January.  In that bug, in comments, I explain it in a more detailed way, but
my patch contains the correct way to handle theme colors as Excel appears to handle them.
 I included changes and additions to the necessary JUnit test case files as well.  Additionally,
the bugs 51236, 52079, and 53274 also appear to result from the same root cause that my patch
fixes.

Four months later, nothing has happened.  Is there something else I need to do get this considered
for being committed?  The "Contribution Guidelines" section of the Apache POI website indicates
that the subject must contain "[PATCH]", but I am unable to change the subject.

Can someone please review my patch, and if it's good, commit it?

Thanks for any information.
Randy Gettman
******************************************************************************************

This message may contain confidential or proprietary information intended only for the use
of the 
addressee(s) named above or may contain information that is legally privileged. If you are

not the intended addressee, or the person responsible for delivering it to the intended addressee,

you are hereby notified that reading, disseminating, distributing or copying this message
is strictly 
prohibited. If you have received this message by mistake, please immediately notify us by
 
replying to the message and delete the original message and any copies immediately thereafter.


Thank you. 
******************************************************************************************

CLLD

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message