poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 54920] XSSFDrawing.createCellComment causes CommentsTable to lose reference to comment in cell A1
Date Sat, 25 May 2013 14:25:41 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=54920

--- Comment #2 from Dominik Stadler <dominik.stadler@gmx.at> ---
Created attachment 30323
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30323&action=edit
Proposed fix for

CommentsTable is dangerous as it overwrites comments in A1 because it uses this
column as default reference in newComment(). 

This proposed patch changes this so a reference is always passed to
newComment() and thus can be set immediately. This also avoids having to adjust
the shape later on in the setCol()/setRow() columns.

Adjusted tests and the original test in this bug run fine then.

I am not sure if this breaks API compatibility, is newComment() exported to the
outside? We could add a second newComment(String ref) to fix this in a
compatible way, but this keeps a method which is dangerous to use anyway...

Another option to fix this would be to use a reference which does not exist in
normal sheets, e.g. something like A0, but I did not look into this yet, any
thoughts?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message