poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 54982] [PATCH] ExtractorFactory does not close files when extracting via OCPPackage.open()
Date Sat, 25 May 2013 16:23:24 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=54982

--- Comment #2 from Dominik Stadler <dominik.stadler@gmx.at> ---
Hmm, I did some more tests and unit tests, it seems to work as far as I see,
however if you state the class is dormant, I'll stop on this Bug.

The Extractor-stuff was an easy way to read the text from an Excel file in unit
tests, having to use another framework like Tika just for this would bloat the
unit test framework, so I am currently using a locally fixed version of the
ExtractorFactory which works fine for my purposes.

BTW, I also saw something like this in the class, which makes no sense at all,
using a locally created lock is not doing anything useful:

        // Save the content
        ReentrantReadWriteLock l = new ReentrantReadWriteLock();
        try {
            l.writeLock().lock();
                        ...


Maybe at least the description at http://poi.apache.org/text-extraction.html
should state that the classes are dormant instead of sending users to a broken
class that is not updated currently...

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message