poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 53130] [PATCH] SXSSF Shared Strings option support, to make generated xlsx files compatible with Google Docs or iPad
Date Sat, 09 Nov 2013 09:44:00 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=53130

--- Comment #10 from Martin Andersson <martin.andersson@purplescout.se> ---
Hi,

I need this patch too. I'm willing to dig in and help if needed.

What concerns me though is that the new contructor

SXSSFWorkbook(XSSFWorkbook workbook, int rowAccessWindowSize, boolean
useSharedStringsTable)

conflicts with the old

SXSSFWorkbook(XSSFWorkbook workbook,
             int rowAccessWindowSize,
             boolean compressTmpFiles)

That's going to break things for users upgrading poi after this patch.

All these constructors are quite confusing. Why not add only one with all four
options?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message