poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 55904] [PATCH] Cell getHyperlink returns null when the link is drag copied in excel
Date Sun, 11 Sep 2016 06:51:53 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=55904

Javen O'Neal <onealj@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34232|0                           |1
        is obsolete|                            |

--- Comment #10 from Javen O'Neal <onealj@apache.org> ---
Created attachment 34233
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34233&action=edit
enable multi-cell XSSFHyperlinks, find multi-cell hyperlinks

Merge unit tests from attachment 33479 with XSSFSheet changes from attachment
34232.

The XSSFHyperlink class assumes that hyperlinks belong to a single cell.
 * XSSFHyperlink.setFirstRow and setLastRow do the same thing, same as
setFirst/LastColumn.
 * XSSFHyperlink.setCellAddress(String ref) breaks if ref is an area reference.

This patch fixes the above problems. I need to verify that XSSFHyperlinks are
really objects within an XSSFSheet rather than an XSSFCell (only one hyperlink
object exists for a multi-cell hyperlink), and then I will commit these
changes.
Note that this patch breaks backwards compatibility: before it was sufficient
to set first row and column on a hyperlink and it would move the single-cell
hyperlink. With the attached code, both the first and last cell will need to be
set to avoid expanding a single-cell hyperlink to an area spanned by the upper
left and lower right cells. Additionally, it is inefficient to set these cells
individually, both in terms of CPU instructions and lines of code. Additional
work will need to be done on the Hyperlink class to allow multi-cell
hyperlinks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message