poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 61745] [PATCH] Added Support To create chart object For DOCX
Date Sun, 12 Nov 2017 00:21:02 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=61745

--- Comment #8 from Javen O'Neal <onealj@apache.org> ---
Thank you for adding support for charts in XWPF!

Would you be able to write some unit tests (or modify existing ones) to cover
the new and changed functionality? See
https://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFPictureData.java?view=log
for an example.

Would you also be able to make the following changes:
XWPFDocument#getCharts:
return Collections.unmodifiableList(charts);

XWPFChart:
Remove @Deprecated API's in XWPFChart. No need for deprecated API's in new
code.
Update javadocs to @since POI 4.0.0

It looks like this was modeled after XWPFPictureData. To whoever ends up
committing this code to the svn repo, an "svn cp XWPFPictureData.java
XWPFChart.java; cp patch.tar.gz/XWPFChart.java ." might make sense.
If there's any code that XWPFChart and XWPFPictureData share in common, it may
make sense to create a class that implements the common methods.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message