poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 61745] [PATCH] Added Support To create chart object For DOCX
Date Sun, 12 Nov 2017 21:54:15 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=61745

--- Comment #11 from Javen O'Neal <onealj@apache.org> ---
Applied attachment 35522 in r1815047 with a few modifications:

In XWPFChart.java:
> protected void XWPFChart(InputStream is)
doesn't make sense to me. Why is there a method with the same name as the class
that isn't a constructor? I removed this, as well as the body of
onDocumentRead().
I didn't check to see if removing the onDocumentRead body causes problems with
reading a chart in a document.

chartSpace and chart class variables should be final if you don't intend to
change them. (This is how I discovered void XWPFChart, which is not a
constructor.) I made these final.

The output stream should be closed in a try-with-resources block to avoid
leaks.
> chartSpace.save(out, xmlOptions);
I changed this, since we're dropping support for Java 6.

I updated the `@since POI 3.14-Beta1` Javadoc remarks to 4.0.0.

Some of the new files had inconsistent whitespace (tabs) and were missing the
ASL 2.0 license header. I fixed this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message