polygene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niclas Hedhman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (POLYGENE-295) Activation broken
Date Mon, 26 Mar 2018 06:35:00 GMT

    [ https://issues.apache.org/jira/browse/POLYGENE-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413433#comment-16413433

Niclas Hedhman commented on POLYGENE-295:

Ok, part one of the puzzle; I have not learned that Activation and activate() is not used
for services, but ServiceActivation and activateService()... No idea why this distinction

Second part of the puzzle is that the Composite Type must be a subtype of ServiceActivation,
not only the Mixin. That is potentially totally bonkers, and requires ServiceActivation.class
to be added as a Type during assembly, in cases where an alternative Mixin implementation
needs activation. No idea why this requirement exist. There has been discussion on list on
this topic, and there might even be additional Jira issue on it.

> Activation broken
> -----------------
>                 Key: POLYGENE-295
>                 URL: https://issues.apache.org/jira/browse/POLYGENE-295
>             Project: Polygene
>          Issue Type: Bug
>    Affects Versions: 2.0, 2.1, 3.0.0
>            Reporter: Niclas Hedhman
>            Priority: Major
> It is quite possible to get service calls before the activate() method has been called.
For instance, inject a Service into the constructor of an Object and call objectFactory.newObject().
Even if instantiateOnStartup(), the activation is not called first.
> On top of that, we have a general issue that the bootstrap code is not really thread-safe
(no effort was made on that), and lazy-initialization may cause model corruption due to that,
which kind of ties in with the Activation system. I suspect that the above problem is some
kind of mixing of concerns and it gets messed up what is supposed to have happened already.
> Step 1; Fix that activation is ALWAYS called before method calls.
> Step 2; Discuss how to deal with lazy initialization. Either make sure that everything
in Core Runtime is thread-safe, or drop the current lazy initialization, and possibly replace
with a Concern instead (which intercepts the activate() call, and make that happen upon next
method call to the service. That seems to be a lot more straight forward and also inline with
Polygene principles (eat your own dog food).

This message was sent by Atlassian JIRA

View raw message