portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject [jira] Commented: (JS2-61) Move pipeline assembly out of XML and into jetspeed.groovy assembly
Date Wed, 02 Jun 2004 13:31:53 GMT
The following comment has been added to this issue:

     Author: Serge Huber
    Created: Wed, 2 Jun 2004 6:29 AM
       Body:
While we are at it working on pipelines, I was wondering if we should extend their pattern
to work on any kind of object, not just RequestContext objects.

If you look at the current implementation we use RequestContext objects as the context. What
now if I wanted to use a pipeline for a specific operation, without providing a RequestContext
object, but maybe just a Map ? 

I think it might be interesting to revise the Pipeline interface to change this : 
    void invoke (RequestContext context) throws PipelineException;
to : 
    void invoke (Object context) throws PipelineException;
We could then if needed create a RequestPipeline that would provide a wrapper method that
casts the object into a RequestContext.

The reason why I'm proposing this is that I had a need for a pipeline in another project,
and I needed to provide something else than RequestContext.

Anyway, it's just a proposal, but it might make the code a bit more generic (until we actually
start using Java Generics which would probably be an even better solution :)).

---------------------------------------------------------------------
View this comment:
  http://issues.apache.org/jira/browse/JS2-61?page=comments#action_35869

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/JS2-61

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: JS2-61
    Summary: Move pipeline assembly out of XML and into jetspeed.groovy assembly
       Type: Task

     Status: Open
   Priority: Major

    Project: Jetspeed 2
 Components: 
             Other
   Versions:
             2.0-a1

   Assignee: Scott T Weaver
   Reporter: Scott T Weaver

    Created: Fri, 28 May 2004 8:14 AM
    Updated: Wed, 2 Jun 2004 6:29 AM

Description:
Having the pipeline's valve assembly defined within an XML smells funny as it is describing
"guts" (i.e. class names) with in a configuration script instead of assembly.  Moving this
into jetspeed.groovy AND making  the JetpseedPipline extend pico container and deploy it as
a sub-container makes a whole lotta sense to me.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org


Mime
View raw message