portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ate Douma <...@douma.nu>
Subject Re: Failing test cases in in components/portal
Date Fri, 02 Nov 2007 12:24:51 GMT
Thanks Dennis,

I've applied your patch.

Still some more test failures to go, but this already helps a lot!

Regards,

Ate

Dennis Dam wrote:
> Hey Scott,
> 
> I just took a look at it, turns out that because of a change in 
> PageTheme.java (oct 26, '07), the getType() method of a root fragment is 
> not called anymore. This is fixed by removing the expectation on 
> getType() for the mock root fragment. Below is the patch. I will also 
> take a look at the other test issues.
> 
> Dennis
> 
> 
> Index: 
> components/portal/src/test/org/apache/jetspeed/decoration/TestDecorations.java 
> 
> ===================================================================
> --- 
> components/portal/src/test/org/apache/jetspeed/decoration/TestDecorations.java    
> (revision 591276)
> +++ 
> components/portal/src/test/org/apache/jetspeed/decoration/TestDecorations.java    
> (working copy)
> @@ -83,8 +83,6 @@
>         ArrayList list = new ArrayList(1);
>         list.add(childFragment);
>        -        expectAndReturn(fragmentMock, "getType", "layout");
> -               expectAndReturn(fragmentMock, "getFragments", list);
>                  expectAndReturn(atLeastOnce(), fragmentMock, "getId", 
> "001");
> 
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message