portals-portalapps-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sascha Arndt (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (APA-72) No cookie rewriting
Date Tue, 22 Dec 2015 15:14:46 GMT

    [ https://issues.apache.org/jira/browse/APA-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068225#comment-15068225
] 

Sascha Arndt edited comment on APA-72 at 12/22/15 3:14 PM:
-----------------------------------------------------------

Hi Woonsan.

Your suggestion regarding ExecuteHttpClientCommand sounds inherently consistent. I agree with
that.

But what do you think about setting the HttpClientContextBuilder instance in general for the
SimpleReverseProxyServlet (it would be still overridable through getHttpClientContextBuilder())?
I think cookie rewriting is a basic feature for every user. Right now everybody has to extend
the SimpleReverseProxyServlet in order to get cookie handling/rewriting.

Regards,
Sascha


was (Author: saschaa1982):
Hi Woonsan.

Your suggestion regarding ExecuteHttpClientCommand sounds inherently consistent. I agree with
that.

But what do you think about setting the HttpClientContextBuilder instance in general for the
SimpleReverseProxyServlet (it would be still overridable through getHttpClientContextBuilder())?
I think cookie rewriting will be a basic feature for every user. Now everybody has to extend
the SimpleReverseProxyServlet in order to get cookie handling/rewriting.

Regards,
Sascha

> No cookie rewriting
> -------------------
>
>                 Key: APA-72
>                 URL: https://issues.apache.org/jira/browse/APA-72
>             Project: Portals Apps
>          Issue Type: Bug
>          Components: apa-webcontent
>    Affects Versions: apa-webcontent-2.0
>            Reporter: Sascha Arndt
>            Assignee: Woonsan Ko
>
> I have a problem using this maven dependency:
> {code:xml}
> <dependency>
>   <groupId>org.apache.portals.applications</groupId>
>   <artifactId>apa-webcontent2-reverse-proxy</artifactId>
>   <version>2.0</version>
> </dependency>
> {code}
> Using this version of apa-webcontent2-reverse-proxy none of my cookies got rewrited or
send back to the client. After some debugging session I found out, that the CloseableHttpClient
and the ProxyContext were using different CookieStore objects.
> I "patched" it locally replacing "InitHttpClientCommand"s executeInternal-method like
this:
> {code:title=InitHttpClientCommand.java|borderStyle=solid}
> @Override
> protected boolean executeInternal(final ProxyContext context) throws ReverseProxyException,
IOException {
>   CookieStore cookieStore = new BasicCookieStore();
>   CloseableHttpClient httpClient = httpClientBuilder.setDefaultCookieStore(cookieStore).build();
>   context.setCookieStore(cookieStore);
>   context.setHttpClient(httpClient);
>   return false;
> }
> {code}
> Is this a bug, or am I using it wrong?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message