qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John O'Hara" <john.r.oh...@gmail.com>
Subject Re: [java] junit4
Date Thu, 26 Oct 2006 23:04:37 GMT
What's in 4 that merits the major feature number?
I'd like to know what we're throwing away.

John

On 26/10/06, Steve Vinoski <vinoski@iona.com> wrote:
>
> On Oct 26, 2006, at 4:46 PM, Carl Trieloff wrote:
> > Steve,
> >
> > Can we also cross post the maven list and see if a fix is coming or
> > if there is a maven branch that works worth junit4. It seems
> > counter to go backwards, and I would guess that this would be a
> > very common issue for other projects also.
>
> You can see all the gory bug details at [1]. I'm already using the
> latest maven surefire snapshots [2], as I don't think we want to
> entertain building and patching our own local copies, but even the
> latest snapshots don't fix the issues.
>
> I don't know that this is a huge issue for projects already using
> maven, as they know not to try to move ahead to junit4 because of
> this bug. New projects typically don't have a lot of tests, and if
> they go the maven route, they learn up front not to adopt junit4.
> What I've looked at elsewhere seems to use junit 3.8.x. Qpid is
> somewhere in the middle -- we already have a few tests, but for
> whatever reason they're based on junit4. As far as I can see, they
> don't require junit4, and the differences between what's there and
> what's required to use junit3 are largely syntactical.
>
> --steve
>
> [1] <http://jira.codehaus.org/browse/SUREFIRE-31>
> [2] <http://people.apache.org/repo/m2-snapshot-repository/org/apache/
> maven/plugins/maven-surefire-plugin/>
>
> >
> > Carl.
> >
> > Steve Vinoski wrote:
> >> Is there a critical reason for the use of junit4 in the qpid
> >> tests? The reason I ask is that maven2 and junit4 simply do not
> >> get along just yet. Specifically, it's a known bug that the maven
> >> surefire plugin doesn't handle junit4, and while a maven-junit
> >> workaround plugin exists, it's rudimentary and so won't handle the
> >> tests qpid has.
> >>
> >> On my maven branch I've switched the broker subdir tests back to
> >> junit3, and they seem to work OK. But before diving in and
> >> changing other tests, I wanted to see if there's critical need for
> >> junit4 as opposed to junit3 that I'm missing.
> >>
> >> On a related note, in general, the qpid tests need some serious
> >> reorganization, as it looks like unit tests, performance tests,
> >> and system tests are all thrown together under the subdir test
> >> directories. The common subdir has no tests or test subdir at all,
> >> but at least it appears to be semi-tested by tests in other
> >> subdirs. Also, as I've commented before, the unit tests aren't
> >> really unit tests, but are instead really more like system tests.
> >> Maven gives us a very nice standard directory structure that makes
> >> it clear which tests belong where, so given the maven/junit issues
> >> and the need to convert to junit3, I was going to tackle some of
> >> these issues on my branch, but again, would like to get input from
> >> the Qpid community on the above issue before continuing.
> >>
> >> --steve
> >
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message