qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Ritchie (JIRA)" <qpid-...@incubator.apache.org>
Subject [jira] Created: (QPID-11) Move protocol literals from code to AMQConstant
Date Tue, 03 Oct 2006 07:18:19 GMT
Move protocol literals from code to AMQConstant

                 Key: QPID-11
                 URL: http://issues.apache.org/jira/browse/QPID-11
             Project: Qpid
          Issue Type: Improvement
          Components: Java Broker, Java Client
            Reporter: Martin Ritchie
            Priority: Trivial

The current Java code has the odd literal value. Such as this from AMQMessage:

        return _contentHeaderBody.properties instanceof BasicContentHeaderProperties
                &&((BasicContentHeaderProperties) _contentHeaderBody.properties).getDeliveryMode()
== 2;

What is deliverymode 2?

Out of context it makes it hard to understand.  Something like AMQConstants.PersistentDeliveryMode
would help reuse and minimise the impact of any protocol changes.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message