qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steve Vinoski <vino...@iona.com>
Subject Re: svn commit: r473356 - /incubator/qpid/trunk/qpid/java/client/test/src/org/apache/qpid/test/unit/jndi/referenceabletest/JNDIReferenceableTest.java
Date Fri, 10 Nov 2006 15:32:09 GMT
On Nov 10, 2006, at 10:28 AM, Daniel Kulp wrote:

> On Friday November 10 2006 9:59 am, Carl Trieloff wrote:
>> I also believe that we should leave the test in and create a readme
>> that FSContext need to be downloaded to run the test. Any
>> objections to that?
>
> Honestly, I would suggest having a different set of tests for tests  
> that
> cannot run without extra dependencies.   It would be nice to be  
> able to
> run at least some set of tests on a straight checkout (or download  
> of src
> distribution) without having to chase around the net for all the other
> wacky dependencies.

Actually, I agree with that, but I just assumed that we'd leave it in  
for now and fix it later, as the tests really need a lot of work anyway.

--steve

>
>
> Dan
>
>
>
>>
>> Carl.
>>
>> Steve Vinoski wrote:
>>> I would have thought you'd just leave this test in, and require
>>> people to download the FSContext stuff?
>>>
>>> --steve
>>>
>>> On Nov 10, 2006, at 9:40 AM, ritchiem@apache.org wrote:
>>>> Author: ritchiem
>>>> Date: Fri Nov 10 06:40:12 2006
>>>> New Revision: 473356
>>>>
>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=473356
>>>> Log:
>>>> Fixed ant error due to lack of fscontext jar
>>>>
>>>> Modified:
>>>>
>>>> incubator/qpid/trunk/qpid/java/client/test/src/org/apache/qpid/ 
>>>> test/
>>>> unit/jndi/referenceabletest/JNDIReferenceableTest.java
>>>>
>>>>
>>>> Modified:
>>>> incubator/qpid/trunk/qpid/java/client/test/src/org/apache/qpid/ 
>>>> test/
>>>> unit/jndi/referenceabletest/JNDIReferenceableTest.java
>>>>
>>>> URL:
>>>> http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/java/ 
>>>> client/t
>>>> est/src/org/apache/qpid/test/unit/jndi/referenceabletest/ 
>>>> JNDIReferenc
>>>> eableTest.java?view=diff&rev=473356&r1=473355&r2=473356
>>>>
>>>> =================================================================== 
>>>> =
>>>> ==========
>>>>
>>>> ---
>>>> incubator/qpid/trunk/qpid/java/client/test/src/org/apache/qpid/ 
>>>> test/
>>>> unit/jndi/referenceabletest/JNDIReferenceableTest.java (original)
>>>> +++
>>>> incubator/qpid/trunk/qpid/java/client/test/src/org/apache/qpid/ 
>>>> test/
>>>> unit/jndi/referenceabletest/JNDIReferenceableTest.java Fri Nov 10
>>>> 06:40:12 2006
>>>> @@ -21,6 +21,7 @@
>>>>  import org.junit.Assert;
>>>>  import org.junit.After;
>>>>  import org.junit.Before;
>>>> +import org.junit.Ignore;
>>>>  import org.apache.qpid.client.transport.TransportConnection;
>>>>  import
>>>> org.apache.qpid.client.vmbroker.AMQVMBrokerCreationException;  
>>>> import
>>>> junit.framework.JUnit4TestAdapter;
>>>> @@ -60,6 +61,8 @@
>>>>          TransportConnection.killVMBroker(1);
>>>>      }
>>>>
>>>> +
>>>> +    @Ignore("FSContext has been removed from repository. This  
>>>> needs
>>>> redone with the PropertiesFileInitialContextFactory. QPID-84")
>>>>      @Test
>>>>      public void referenceable()
>>>>      {
>
> -- 
> J. Daniel Kulp
> Principal Engineer
> IONA
> P: 781-902-8727    C: 508-380-7194   F:781-902-8001
> daniel.kulp@iona.com


Mime
View raw message