qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Ritchie" <ritch...@apache.org>
Subject Re: svn commit: r475297 - /incubator/qpid/trunk/qpid/java/broker/src/org/apache/qpid/server/Main.java
Date Wed, 15 Nov 2006 17:15:05 GMT
My appologies I didn't reallise you couldn't pickup the head of mina.
I thought the snapshot you were using just vanished not the ability to
get the head. We can of course revert all the mina changes I made but
it would have been nice for a comment on the JIRA to help me
understand that making the changes would not help the problem we are
facing with maven.

Annoying as it is there are a number of issues with mina 1.0.0 which
the team are aware of and are trying to get a 1.0.1 release out soon.
they have started the process but need to get their maven building
their artifacts correctly to suit the release process. (Something I'm
sure we could all work together to sort.)

Is it not possible to use the snapshot we currently have in our
repository and distribute that in our release?

There will hopefully be some improvements to mina before M2 that will
improve the performance of our IO layer, but it is unlikely that they
will be in an official release at that point. Will we be unable to use
thse items?

-- 
Martin

On 15/11/06, Steve Vinoski <vinoski@iona.com> wrote:
> I've seen several mina-related commits go by today related to bring
> code up to mina-HEAD, but I must admit I still don't understand the
> desire to be using code straight from mina that isn't available in a
> maven repository yet.
>
> The reason? Well, yesterday I thought we all agreed to mavenize the
> trunk after M1. These commits prevent that. We can't even be picking
> up mina snapshots, because we can't release M2 or another release
> with snapshot dependencies, unless of course those snapshots turn
> into real releases before M2.
>
> The mvn branch works with released mina 1.0.0. To the best of my
> knowledge, 1.0.0 is the latest official release of mina. I've stated
> that several times, but it just seems to be glossed over and ignored.
>
> What critical bugs are fixed by picking up mina-HEAD? Are they truly
> critical showstoppers that absolutely have to be in trunk today?
>
> --steve
>
> On my b
> On Nov 15, 2006, at 11:21 AM, ritchiem@apache.org wrote:
>
> > Author: ritchiem
> > Date: Wed Nov 15 08:21:02 2006
> > New Revision: 475297
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=475297
> > Log:
> > Removed local development code that made it into the repository
> >
> > Modified:
> >     incubator/qpid/trunk/qpid/java/broker/src/org/apache/qpid/
> > server/Main.java
> >
> > Modified: incubator/qpid/trunk/qpid/java/broker/src/org/apache/qpid/
> > server/Main.java
> > URL: http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/java/
> > broker/src/org/apache/qpid/server/Main.java?
> > view=diff&rev=475297&r1=475296&r2=475297
> > ======================================================================
> > ========
> > --- incubator/qpid/trunk/qpid/java/broker/src/org/apache/qpid/
> > server/Main.java (original)
> > +++ incubator/qpid/trunk/qpid/java/broker/src/org/apache/qpid/
> > server/Main.java Wed Nov 15 08:21:02 2006
> > @@ -320,19 +320,7 @@
> >
> >              SocketSessionConfig sc;
> >
> > -            //fixme improve get to use configuration
> > -            if (connectorConfig.qpidNIO)
> > -            {
> > -                //FIXME - this needs to be sorted to use the new
> > Mina MultiThread SA.
> > -                _logger.warn("Using Qpid NIO - DISABLED");
> > -                //sconfig =
> > (org.apache.mina.transport.socket.nio.MultiThreadSocketAcceptorConfig)
> >  acceptor.getDefaultConfig();
> > -                //sc = (SocketSessionConfig)
> > sconfig.getSessionConfig();
> > -            }
> > -//            else
> > -            {
> > -                _logger.warn("Using Mina NIO");
> > -                sc = (SocketSessionConfig)
> > acceptor.getSessionConfig();
> > -            }
> > +            sc = (SocketSessionConfig) acceptor.getSessionConfig();
> >
> >              sc.setReceiveBufferSize
> > (connectorConfig.socketReceiveBufferSize);
> >              sc.setSendBufferSize
> > (connectorConfig.socketWriteBuferSize);
> >
> >
>
>

Mime
View raw message