qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Ritchie" <ritch...@apache.org>
Subject Re: [ANN] Release Candidate
Date Tue, 21 Nov 2006 09:56:42 GMT
1 & 2. The duplication was due to the ant target being run on a dirty
working directory. I have a fix that will prevent that occurring that
I am in the process of testing.

3 Should now be addressed if we put a licence.amqp.txt file in the
spec directory.

On 21/11/06, Cliff Schmidt <cliffschmidt@gmail.com> wrote:
> On 11/20/06, Rajith Attapattu <rajith77@gmail.com> wrote:
> > Hey Cliff,
> >
> > Thanks for the great feedback. I will start working on these items.
> > I will wait for a full review by you (and others as well) before
> > cutting another RC.
> > Hopefully if I receive all the feedback today I could do it at night
> > or maybe first thing in the morning.
>
> Here's the only other stuff I came up with during a more thorough review:
>
> 1. For some reason there's a duplicate set of LICENSE in the /java
> directory of the -src distro.  While not needed, it's okay to be there
> as long as you keep it in synch with the root copy.
>
> 2. The src distribution seems to have two specs directory, one at the
> root and one in /src.  Was this intentional?
>
> 3. The spec license also needs to be mentioned in the LICENSE file
> just like the other licenses.
>
> 4.  And this is the most significant item: the license for the spec
> appears to still not include the right to 'distribute'.  I pointed
> this issue out when this project was being proposed.  It definitely
> needs to be fixed before including the spec in an Apache distribution.
>
> Cliff
>


-- 
Martin Ritchie

Mime
View raw message