qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Meyering <...@meyering.net>
Subject Re: Small performance issue
Date Fri, 15 Dec 2006 18:33:08 GMT
Kim van der Riet <kim.vdriet@redhat.com> wrote:
> I'll get to this later this afternoon. Thanks for the patch.
>
> There is a function to do this already in CppGenerator: setRef(), which
> changes both string and FieldTable to const &. A shorter (but
> equivalent) change would be:
>
> -			sb.append(indent + (defineFlag ? fieldDomainPair[FIELD_DOMAIN] + " " : "") +
> +                       sb.append(indent + (defineFlag ? setRef(fieldDomainPair[FIELD_DOMAIN])
+ " " : "") +

Yes, that looks better, indeed :-)
I suppose it's ok to transform "FieldTable" as well as "string".

Mime
View raw message