qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alan Conway <acon...@redhat.com>
Subject Re: Qpid C++ header file includes
Date Mon, 15 Jan 2007 15:18:52 GMT
On Mon, 2007-01-15 at 14:52 +0000, Andrew Stitcher wrote:
> On Mon, 2007-01-15 at 09:42 -0500, Kim van der Riet wrote:
> > On Mon, 2007-01-15 at 14:38 +0000, Gordon Sim wrote: 
> > > Prefix with the namespaces? e.g. qpid_broker_SessionHandlerFactoryImpl_?
> > 
> > Unless we can turn up a well-defined standard or pattern, I think this
> > is as good a suggestion as any.
> 
> I think there are two natural solutions -
> * Use the file system hierarchy
> * Use the namespace hierarchy
> 
> I think the namespace hierarchy gives a more robust solution so I'd
> agree with this solution. We also need to use a scheme so that normal
> variables can't accidentally get the same name, so putting something in
> uppercase might be a good idea say:
> 
> QPID_BROKER_SessionHandlerFactoryImpl
> 
> or maybe use a double underscore at the end as we don't use that
> anywhere else:
> 
> qpid_broker_SessionHandlerFactoryImpl__

Either works, I prefer upcasing but don't really care as long as its
consistent.

Cheers,
Alan.


Mime
View raw message