qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carl Trieloff <cctriel...@redhat.com>
Subject Re: missing ruby dependency check in autoconf -- patch
Date Wed, 05 Sep 2007 21:14:54 GMT

Thanks, applied
Carl.


Nuno Santos wrote:
>
> I noticed that the dependency check for ruby (needed for the code 
> generator) in configure.ac in the C++ trunk would allow the build to 
> proceed even if ruby is missing. Since the build can't really complete 
> without the code generator's output, this check should cause configure 
> to abort if it can't find ruby in the system.
>
> I'm attaching a patch to address this issue (changes to configure.ac, 
> and also to README, to reflect the need to yum ruby upon installation 
> from source).
>
> Nuno
> ------------------------------------------------------------------------
>
> Index: README
> ===================================================================
> --- README      (revision 573040)
> +++ README      (working copy)
> @@ -60,7 +60,7 @@
>  
>  On linux most packages can be installed using your distribution's package
>  management tool. For example on Fedora:
> -  # yum install pkgconfig e2fsprogs boost-devel cppunit-devel openais
> +  # yum install pkgconfig e2fsprogs boost-devel cppunit-devel openais ruby
>    # yum install make gcc-c++ autoconf automake libtool doxygen help2man graphviz
>  
>  Follow the manual installation instruction below for any packages not
> Index: configure.ac
> ===================================================================
> --- configure.ac        (revision 573040)
> +++ configure.ac        (working copy)
> @@ -117,6 +117,7 @@
>  
>  AC_CHECK_PROG([RUBY], [ruby], [ruby])
>  test -n "$RUBY" && generate=yes
> +test -z "$RUBY" && AC_MSG_ERROR([Missing ruby installation (try "yum install
ruby").])
>  
>  specdir=`pwd`/$srcdir/../specs  
>  AMQP_XML=$specdir/amqp-transitional.0-10.xml
>   


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message