qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Godfrey (JIRA)" <qpid-...@incubator.apache.org>
Subject [jira] Resolved: (QPID-11) Move protocol literals from code to AMQConstant
Date Wed, 12 Dec 2007 09:56:43 GMT

     [ https://issues.apache.org/jira/browse/QPID-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rob Godfrey resolved QPID-11.
-----------------------------

       Resolution: Won't Fix
    Fix Version/s:     (was: M3)

> Move protocol literals from code to AMQConstant
> -----------------------------------------------
>
>                 Key: QPID-11
>                 URL: https://issues.apache.org/jira/browse/QPID-11
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker, Java Client
>    Affects Versions: M1, M2
>            Reporter: Martin Ritchie
>            Priority: Trivial
>
> The current Java code has the odd literal value. Such as this from AMQMessage:
>         return _contentHeaderBody.properties instanceof BasicContentHeaderProperties
>                 &&((BasicContentHeaderProperties) _contentHeaderBody.properties).getDeliveryMode()
== 2;
> What is deliverymode 2?
> Out of context it makes it hard to understand.  Something like AMQConstants.PersistentDeliveryMode
would help reuse and minimise the impact of any protocol changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message