qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Farrellee (JIRA)" <qpid-...@incubator.apache.org>
Subject [jira] Commented: (QPID-1070) Patch to allow configure options to set Boost header and lib locations
Date Sun, 18 May 2008 01:39:55 GMT

    [ https://issues.apache.org/jira/browse/QPID-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597773#action_12597773
] 

Matthew Farrellee commented on QPID-1070:
-----------------------------------------

Looks good.

When someone applies this they may want to apply the help2man patch separately/first, which
also looked good. Also, they should handle --without-boost with a warning/error since --without-boost
won't build without boost, it'll just set qpid_boost_root to "no"


> Patch to allow configure options to set Boost header and lib locations
> ----------------------------------------------------------------------
>
>                 Key: QPID-1070
>                 URL: https://issues.apache.org/jira/browse/QPID-1070
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client
>    Affects Versions: M3
>         Environment: RHEL 4
>            Reporter: Steve Huston
>            Priority: Minor
>
> The default (at least in 1.35) Boost install locations are in /usr/local (/usr/local/include/boost-1_35/boost
and /usr/local/lib). These locations are not searched by g++ without additional options. This
patch allows the following options to be supplied to the configure script:
> --with-boost=DIR
> --with-boost-include=DIR
> --with-boost-libdir=DIR
> The patch also includes changes related to 1068 (the first section from line 26)
> Index: configure.ac
> ===================================================================
> --- configure.ac        (revision 657445)
> +++ configure.ac        (working copy)
> @@ -26,7 +26,8 @@
>  # AM_MISSING_PROG([HELP2MAN], [help2man])
>  AC_CHECK_PROG([HELP2MAN], [help2man], [help2man])
> -test -z "$HELP2MAN" && AC_MSG_ERROR([Missing help2man installation (try "yum
install help2man").])
> +test -z "$HELP2MAN" && AC_MSG_WARN([Missing help2man installation. Man pages
will not be generated.])
> +AM_CONDITIONAL([GENERATE_MAN], [test X$HELP2MAN != X])
>  AC_ARG_ENABLE(warnings,
>  [  --enable-warnings   turn on lots of compiler warnings (recommended)],
> @@ -132,6 +133,38 @@
>  DOWNLOAD_URL=http://rhm.et.redhat.com/download
>  AC_SUBST(DOWNLOAD_URL)
> +# Allow Boost to be somewhere that requires compile and/or link options.
> +qpid_BOOST_CPPFLAGS=""
> +qpid_BOOST_LDFLAGS=""
> +AC_ARG_WITH([boost],
> +   AS_HELP_STRING([--with-boost@<:@=DIR@:>@],
> +                 [root directory of Boost installation]),
> +   [
> +   qpid_boost_root="${withval}"
> +   if test "${qpid_boost_root}" != yes; then
> +       qpid_boost_include="${qpid_boost_root}/include"
> +       qpid_boost_libdir="${qpid_boost_root}/lib"
> +   fi
> +   ])
> +
> +AC_ARG_WITH([boost-include],
> +   AS_HELP_STRING([--with-boost-include=DIR],
> +                  [specify exact directory for Boost headers]),
> +   [qpid_boost_include="$withval"])
> +
> +AC_ARG_WITH([boost-libdir],
> +   AS_HELP_STRING([--with-boost-libdir=DIR],
> +                  [specify exact directory for Boost libraries]),
> +   [qpid_boost_libdir="$withval"])
> +
> +if test "${qpid_boost_include}"; then
> +   CPPFLAGS="$CPPFLAGS -I${qpid_boost_include}"
> +fi
> +
> +if test "${qpid_boost_libdir}"; then
> +   LDFLAGS="$LDFLAGS -L${qpid_boost_libdir}"
> +fi
> +
>  # Check for headers from required devel kits.
>  AC_CHECK_HEADERS([boost/shared_ptr.hpp uuid/uuid.h],,
>    AC_MSG_ERROR([Missing required header files.]))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message