qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Ritchie (JIRA)" <qpid-...@incubator.apache.org>
Subject [jira] Commented: (QPID-432) Client Code doesn't correctly close a JMSSession/Channel when the broker demands it.
Date Wed, 23 Jul 2008 15:58:31 GMT

    [ https://issues.apache.org/jira/browse/QPID-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616133#action_12616133
] 

Martin Ritchie commented on QPID-432:
-------------------------------------

The ChannelCloseMethodHandler in client still only calls session.channelClosed in success
cases so there may still be an issue of double closures.

Not sure where propagated exception is being ignored in AMQProtocolSession but it does now
(as of QPID-940) propagate exceptions sent via notifyError()

We don't have a ChannelCloseException anymore but in ConnectionCloseMH we now correctly throw
the exception back via session.notifyError() before closing the connection.

> Client Code doesn't correctly close a JMSSession/Channel when the broker demands it.
> ------------------------------------------------------------------------------------
>
>                 Key: QPID-432
>                 URL: https://issues.apache.org/jira/browse/QPID-432
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: M3
>
>
> When a Channel exception occurs the Java client propogates the error but doesn't remove
the JMSSession mapping from the connection so when connection.close is called the already
closed AMQP-Channel is closed again.. resulting in a ConnectionException.
> See AMQProtocolSession for where the execption is progogated and ignored 
> See Also ChannelCloseException for where the session is only removed from the map when
a channel close is received with error code REPLY_SUCCESS other wise it thows an exception
before calling this code.. should the code be in a finally?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message