qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajith Attapattu" <rajit...@gmail.com>
Subject Re: Java Test change
Date Tue, 15 Jul 2008 17:51:55 GMT
I am +1 with this change.
However we need to ensure that systests are run as part of a regular build.
(I believe this is currently the case).

Regards,

Rajith

On Tue, Jul 15, 2008 at 9:03 AM, Martin Ritchie <ritchiem@apache.org> wrote:

> Hi,
>
> Just wanted to give everyone a heads up that I've needed to make
> changes in the tests to fix a few test failures.
>
> The change to QpidTestCase etc have been discussed as part of
> QPID-1079 and are assigned to Arnaud to to do:
>
> http://cwiki.apache.org/confluence/display/qpid/Qpid+Java+Meeting+Minutes+2008-07-11
>
> However, I'm trying to get trunk passing our tests(java and C++) 100%.
>
> The code review change is to move QpidTestCase to a new shared module
> that client can depend on for testing.
>
> I would argue that the client module should not be dependant directly
> or indirectly on the broker. So the large change I am looking to
> commit is move all tests that utilise QpidTestCase to systests. This
> will leave only pure unit tests in the client package.
>
> Does anyone have any objections/thoughts?
>
> Cheers
>
> Martin
>
> --
> Martin Ritchie
>



-- 
Regards,

Rajith Attapattu
Red Hat
http://rajith.2rlabs.com/

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message