qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Ritchie (JIRA)" <qpid-...@incubator.apache.org>
Subject [jira] Created: (QPID-1433) BlockingWaiters will drop locks on error notifcation
Date Wed, 05 Nov 2008 12:33:44 GMT
BlockingWaiters will drop locks on error notifcation
----------------------------------------------------

                 Key: QPID-1433
                 URL: https://issues.apache.org/jira/browse/QPID-1433
             Project: Qpid
          Issue Type: Bug
          Components: Java Client
    Affects Versions: M3, M2.1
            Reporter: Martin Ritchie
            Assignee: Martin Ritchie
            Priority: Critical
             Fix For: M4


Summary:

BlockingWaiter.error() has an incorrect use of lock();

All lock() calls must be immediately followed by a try finally{release()} block.

In the BlockingWaiter case the lock is lost if the BlockingWaiter is closed. L245-248 : If(_closed)
return;

It is very unlikely that our BlockingWaiter will receive more than one error but if a closed
BlockingWaiter did receive a second error then that second thread would block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message