qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aidan Skinner (JIRA)" <qpid-...@incubator.apache.org>
Subject [jira] Updated: (QPID-1503) Base64MD5PasswordFile does not write end of line in header section
Date Mon, 08 Dec 2008 16:14:44 GMT

     [ https://issues.apache.org/jira/browse/QPID-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Aidan Skinner updated QPID-1503:

    Status: Open  (was: Ready To Review)

Looks good generally, couple of nits:

User should probably be called something that implys it's the MD5hashed one.
getEncodePassword should be getEncodedPassword()
toString() shouldn't have the isDebugEnabled branch

Those are all extant problems though. The one biggy is that Base64MD5PasswordPrincipalDatabaseTest
uses existing file names and system propertys. It should use createTemporaryFile instead.

> Base64MD5PasswordFile does not write end of line in header section
> ------------------------------------------------------------------
>                 Key: QPID-1503
>                 URL: https://issues.apache.org/jira/browse/QPID-1503
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Management : JMX Console, Starter
>    Affects Versions: M3
>            Reporter: Martin Ritchie
>            Assignee: Aidan Skinner
> Summary
> B64MD5 PasswordFile  L: 400 is write() but is missing a println afterwards which causes
the comment rows to merge with the next row.
> This will cause the first user to be disabled.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message