qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Gemmell (JIRA)" <qpid-...@incubator.apache.org>
Subject [jira] Commented: (QPID-1655) AMQUserManagementMBean is unable to save the jmx user access rights file, but does not signal this to calling methods
Date Mon, 09 Feb 2009 21:43:59 GMT

    [ https://issues.apache.org/jira/browse/QPID-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672023#action_12672023
] 

Robert Gemmell commented on QPID-1655:
--------------------------------------

This can be resolved with a rudimentary fix of changing Line 396 to not use the absolute file
location from _accessFileName. However, a more appropriate fix would be to update the saveaccessfile
method to report success to the calling methods rather than it being assumed as present, and
the calling methods updated to take appropriate action in the event it should fail. Additionally
a test should be added to ensure changes are written to the file. I will do this later in
the week.

> AMQUserManagementMBean is unable to save the jmx user access rights file, but does not
signal this to calling methods
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-1655
>                 URL: https://issues.apache.org/jira/browse/QPID-1655
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M4
>            Reporter: Robert Gemmell
>             Fix For: M5
>
>
> AMQUserManagementMBean is unable to save the jmx user access rights file, however it
does not report this to the calling methods and so no error is reported. The changes may appear
to take effect because the cached values are updated.
> On line 396 within the saveaccessfile method,  _accessFileName is used as the prefix
to create a temporary file, however _accessFileName contains an absolute filesystem path and
its use causes an FileNotFound IOException, which the method catches and then does nothing
with except output a log message, so the calling methods are unaware the save has failed:
> 2009-02-09 10:23:28,608 WARN  [RMI TCP Connection(4)-127.0.1.1] management.AMQUserManagementMBean
(AMQUserManagementMBean.java:413) - Problem occured saving '/home/gemmellr/workspace/eclipse/qpid_trunk/qpid/java/build/etc/jmxremote.access'
changes may not be preserved. :java.io.IOException: No such file or directory

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message