qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Ritchie (JIRA)" <qpid-...@incubator.apache.org>
Subject [jira] Commented: (QPID-1632) Move reference counting from AMQMessage and Queue classes to TransactionLog
Date Wed, 18 Feb 2009 13:03:01 GMT

    [ https://issues.apache.org/jira/browse/QPID-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674598#action_12674598
] 

Martin Ritchie commented on QPID-1632:
--------------------------------------

I've been adding reference counting testing against the BDBMessageStore module. 

Everything looks ok except the NoAck messaging case. The data is not removed from the store:

The questions I have are:
Why is the NoAck case not purging the reference.
Why is there no logging from the QEI.dispose methods

I added logging to the QueueEntryImpl to log when the dispose is called which occurs when
the reference count hits zero and the data should be deleted. I got no logging and the data
remains.

Whilst this is an interesting from a testing of the existing code base PoV removing the reference
counting and making the new TransactionLog responsible for the management of its own data
will resolve this issue.

> Move reference counting from AMQMessage and Queue classes to TransactionLog
> ---------------------------------------------------------------------------
>
>                 Key: QPID-1632
>                 URL: https://issues.apache.org/jira/browse/QPID-1632
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Broker
>    Affects Versions: M4
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: M5
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Reference counting in the Java broker has caused a number of problems. By consolidating
it in the TransactionLog we can unit test it to validate its behaviour. 
> The reference counting updates are spread throughout the code base so there will be a
bit of clean up required.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message