qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gordon Sim (JIRA)" <qpid-...@incubator.apache.org>
Subject [jira] Commented: (QPID-1709) configure.ac: make output when no specs are present more friendly?
Date Wed, 04 Mar 2009 13:21:58 GMT

    [ https://issues.apache.org/jira/browse/QPID-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678727#action_12678727
] 

Gordon Sim commented on QPID-1709:
----------------------------------

I agree that looks like a worthwhile improvement for M5.

> configure.ac: make output when no specs are present more friendly?
> ------------------------------------------------------------------
>
>                 Key: QPID-1709
>                 URL: https://issues.apache.org/jira/browse/QPID-1709
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Build Tools
>    Affects Versions: M4
>         Environment: Linux
>            Reporter: Steve Huston
>            Priority: Trivial
>             Fix For: M5
>
>
> This came up on the users list... if a user with a released version of the C++ kit (say,
M4) runs configure and it detects that there's no xml spec, all that shows in the output is
the error from 'ls' saying there's no xml file. I think it may be better to inform the user
of what's going on, with output such as:
> ...
> checking for rpmlint... no
> checking for ruby... ruby
> configure: AMQP specs not present; source code will not be generated.
> checking boost/shared_ptr.hpp usability... yes
> ...
> This is with the following patch to configure.ac:
> Index: configure.ac
> ===================================================================
> --- configure.ac        (revision 749505)
> +++ configure.ac        (working copy)
> @@ -150,8 +150,9 @@
>  
>  specdir=`pwd`/$srcdir/../specs  
>  AMQP_FINAL_XML=$specdir/amqp.0-10-qpid-errata.xml
> +test -f $AMQP_FINAL_XML || AC_MSG_NOTICE([AMQP specs not present; source code will not
be generated.])
>  AC_SUBST(AMQP_FINAL_XML)
> -AM_CONDITIONAL([GENERATE], [ls $AMQP_FINAL_XML >/dev/null])
> +AM_CONDITIONAL([GENERATE], [test -f $AMQP_FINAL_XML])
>  
>  # URL and download URL for the package.
>  URL=http://rhm.et.redhat.com/qpidc
> What do you think about this in general, and about commiting it for M5?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message