qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aidan Skinner <aidan.skin...@gmail.com>
Subject Re: RFC: Maven and the Java Build
Date Fri, 26 Jun 2009 12:36:43 GMT
On Fri, Jun 26, 2009 at 12:27 PM, Rafael Schloming <rafaels@redhat.com> wrote:

> Aidan Skinner wrote:

>> Admittedly
>> commons-lang=lib/commons-lang-2.2.jar
>> is more concise than
>> <dependency org="commons-lang" name="commons-lang" rev="2.2"/>
>>
>> But it's not a huge hardship if we can then guarantee meaningful poms
>> that are automatically generated.
>
> I don't think we could actually guarantee this. Imagine if there were a typo in the org
part:
>
> <dependency org="commns-lang" name="commons-lang" rev="2.2"/>
>
> This could easily happen, and we wouldn't notice either because we don't use the org
part or we have the same typo in the path to the file on disk. This would result in a useless
pom that could easily get included into the release artifact and then signed and voted for
release. And once that happens, we can't go back and fix it.

It's pretty trivial to automate those sort of checks.

> IMHO it's really a bad idea to sign the pom regardless, because even if it's correct
at the time of release, it may become out of date after the release since it depends on external
configuration that may change.

I don't see how that differs from the usual "I am using maven"
situation for them, and I don't see how that relates to signing the
pom in any case.

> I'm also not sure how we could automatically test this in a reasonable way without actually
firing up maven, and that would sort of defeat the purpose. I know we could possibly test
that ivy can find the remote dependency without firing up maven, but from what I hear maven
and ivy have different behavior wrt poms and so some poms work with one and not the other.

Firing up maven in the test suite is, surely, different from using it
as the main build tool? It shouldn't affect anything other than the
automated testing step and it would be easy to allow that to be
disabled if you were building in an isolated environment.

- Aidan
--
Apache Qpid - AMQP, JMS, other messaging love http://qpid.apache.org
"A witty saying proves nothing" - Voltaire

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message