qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Ritchie <ritch...@apache.org>
Subject Re: QPID-2028 : Broker test clean up and NullApplicationRegistry
Date Tue, 04 Aug 2009 15:50:03 GMT
2009/8/4 Rafael Schloming <rafaels@redhat.com>:
> Martin Ritchie wrote:
>>
>> Just a quick heads up that as part of this work I want to move teh
>> NullApplicationRegistry from the main broker package to the test
>> package. The NAR will never be used in normal operation as we use the
>> ConfigurationFileAR. The NAR is only used for testing.
>>
>> This move would of course highlight that in the test package we
>> already have a TestApplicationRegistry. Ideally both of these test ARs
>> should be removed and we should only use the ConfigurationFileAR.
>>
>> The affects for Java developers is that if you have your IDE set up to
>> maintain the same dependencies the build system has then you will need
>> to update your Management Eclipse package to include the broker/test
>> package as this creates an ApplicationRegistry with the NAR.
>
> Are you saying that the management/eclipse-plugin module will now depend on
> broker/test?

The desired changed would be to add broker/test to the test dependencies:
    <property name="module.test.depends" value="broker/test" />
So only the modules tests would depend on the broker/test package.
Currently it depends on the test logic of the NullApplicationRegistry
which really should be removed and is only used by test code, even
though it lives in the broker/main package.

Having the management/eclipse-plugin use a proper ConfigurationFileAR
would perhaps be the best way to proceed especially as it further
reduces our use of the NAR.

What were your thoughts on the change?

Cheers

Martin
> --Rafael
>
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project:      http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
>



-- 
Martin Ritchie

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message