qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marnie McCormack (JIRA)" <qpid-...@incubator.apache.org>
Subject [jira] Resolved: (QPID-2041) failed update to the Base64MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart
Date Tue, 15 Dec 2009 11:23:18 GMT

     [ https://issues.apache.org/jira/browse/QPID-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Marnie McCormack resolved QPID-2041.
------------------------------------

    Resolution: Fixed

Reviewed changes, as per similar changes to use of random rather than tmp location for file
writes during update. Looks fine to me. 

> failed update to the Base64MD5PasswordFilePrincipalDatabase on disk may go unnoticed,
preventing broker restart
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2041
>                 URL: https://issues.apache.org/jira/browse/QPID-2041
>             Project: Qpid
>          Issue Type: Bug
>    Affects Versions: M3, M4, 0.5
>            Reporter: Robbie Gemmell
>            Assignee: Martin Ritchie
>            Priority: Critical
>             Fix For: 0.6
>
>
> failed update to the MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing
broker restart
> Certain use of the File.renameTo() function is not accompanied by a check of the boolean
result, meaning a failed rename can leave the file in the wrong location, but the cached nature
of the Base64MD5PasswordFilePrincipalDatabase masks the failure until another operation is
attempted upon it that needs the output of the previously failed update. This has been observed
in a situation where the OS Temp dir is on one (local) file system, and the broker configuration
is on another (remote NFS) filesystem, which caused the rename to fail unnoticed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message