qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Ritchie <ritch...@apache.org>
Subject Re: Unused 0-10 MessageDelegate constructor
Date Mon, 07 Dec 2009 15:23:20 GMT
I did the removal as a single commit (r887951) so if we want it back
it is easy to do, but thought it best to keep the 'seemingly dead
code' to a minimum.

Cheers
Martin

2009/12/7 Martin Ritchie <ritchiem@apache.org>:
> Hi,
>
> I'm working on QPID-2242 and notice that whilst the 0-10 code path has
> a solution to the problem it is not used.
>
> This constructor:
> protected AMQMessageDelegate_0_10(long deliveryTag, MessageProperties
> messageProps, DeliveryProperties deliveryProps,-
>               AMQShortString routingKey) throws AMQException
>
> Would correctly setup the JMSDestination value however it is not
> called from the Qpid code base.
>
> Would there be any objections to removing the constructor and
> correctly setting the JMSDestination value in the used constructor?
>
> Cheers
>
> Martin
> --
> Martin Ritchie
>



-- 
Martin Ritchie

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message