qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gordon Sim (JIRA)" <qpid-...@incubator.apache.org>
Subject [jira] Commented: (QPID-2320) Failed acquire on LVQ causes broker crash
Date Tue, 05 Jan 2010 17:46:54 GMT

    [ https://issues.apache.org/jira/browse/QPID-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796786#action_12796786
] 

Gordon Sim commented on QPID-2320:
----------------------------------

As compared with the pre r834172 logic this removes a check for i->position == msg.position
from the non-lvq case and adds in a test of msg.payload.get(). Is that deliberate?

I think it would be worth adding a comment on what the extra lvq related logic is doing and
why. Its not an easy piece of code to follow.

> Failed acquire on LVQ causes broker crash
> -----------------------------------------
>
>                 Key: QPID-2320
>                 URL: https://issues.apache.org/jira/browse/QPID-2320
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.6
>            Reporter: Gordon Sim
>
> If an acquire fails for an LVQ because the message has already been acquired by some
other subscriber, the failed attempt causes the broker to crash. This is due to lack of proper
bounds checking in Queue::acquire() for the LVQ case and was I believe introduced by http://svn.apache.org/viewvc?view=revision&revision=834172.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message