qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robbie Gemmell (JIRA)" <qpid-...@incubator.apache.org>
Subject [jira] Commented: (QPID-2155) QpidRollingFileAppender has no tests and does not appear to work.
Date Tue, 02 Feb 2010 15:10:19 GMT

    [ https://issues.apache.org/jira/browse/QPID-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828638#action_12828638
] 

Robbie Gemmell commented on QPID-2155:
--------------------------------------

It isnt clear what the following is supposed to accomplish atQCRA line 920. The commit (891331)
message references adding NPE checks, but the testFileName String is constructed immediately
above this and wont be null, and the JavaDoc for File doesnt list anything about nulls other
than it will NPE if the given string is null.

        // Bail out early if there is a problem with the file
        if (new File(testFileName) == null
                || new File(testFileName + COMPRESS_EXTENSION) == null)

        {
            return index;
        }

> QpidRollingFileAppender has no tests and does not appear to work.
> -----------------------------------------------------------------
>
>                 Key: QPID-2155
>                 URL: https://issues.apache.org/jira/browse/QPID-2155
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.5
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: 0.6
>
>
> When investigating QPID-2085 the following issues were found:
> The QpidRollingFileAppender does not appear to behave as expected from the configuration.
> Have noticed the following:
>  - qpid.log being archived shortly after creation, resulting in no log file for the broker.
(When using StaticName)
>  - Log files being archived before 10MB setting, using default configuration.
>  - Log files index not being used as described in the comments. file .0 is always the
current head of the log rather than 'n' as described.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message