qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robbie Gemmell (JIRA)" <qpid-...@incubator.apache.org>
Subject [jira] Commented: (QPID-2155) QpidRollingFileAppender has no tests and does not appear to work.
Date Thu, 04 Feb 2010 10:46:28 GMT

    [ https://issues.apache.org/jira/browse/QPID-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829571#action_12829571
] 

Robbie Gemmell commented on QPID-2155:
--------------------------------------

The MaxSizeRollBackups configuration property to configure the number of backups made wont
work as expected (if not set to unlimited) when used in conjunction with a CountDirection
of 0 (date pattern stamped + positive integer when the date format stamp clashes) and a RollingStyle
of  1 or 2 ( size or both). The MaxSizeRollBackups will only be adhered to in the case where
the date pattern stamp clashes, in which case there will be at most MaxSizeRollBackups files
allowed with the same clashing date pattern stamp. Outwith this situation, an unlimited number
of size rollover backups will occur regardless of the limit set, as the current date pattern
stamp is included within the filename path used to delete the oldest file. 

The filename issue also apples to the countFileIndex method used to determine which integer
to append to the backup filename. At at initial startup with a CountDirection of 0 the curSizeRollBackups
variable will be initialised to 1, except if the current date pattern stamp matches those
on the last files created by the broker before it was restarted. As a result, the broker will
usually restart the count from 1 but if a log backup was created just before the broker restarted
and the date pattern resolution lead to the same stamp being reused the count would continue
from its previous number (possible but not incredibly likely with the provided example config,
as it uses a 10MB size based rollover with 1minute resolution in the date pattern)


> QpidRollingFileAppender has no tests and does not appear to work.
> -----------------------------------------------------------------
>
>                 Key: QPID-2155
>                 URL: https://issues.apache.org/jira/browse/QPID-2155
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.5
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: 0.6
>
>
> When investigating QPID-2085 the following issues were found:
> The QpidRollingFileAppender does not appear to behave as expected from the configuration.
> Have noticed the following:
>  - qpid.log being archived shortly after creation, resulting in no log file for the broker.
(When using StaticName)
>  - Log files being archived before 10MB setting, using default configuration.
>  - Log files index not being used as described in the comments. file .0 is always the
current head of the log rather than 'n' as described.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message