qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Armin Noll (JIRA)" <qpid-...@incubator.apache.org>
Subject [jira] Created: (QPID-2386) Qpid C++ broker: add user ID in "SASL: Authentication failed" log message
Date Wed, 03 Feb 2010 15:23:27 GMT
Qpid C++ broker: add user ID in "SASL: Authentication failed" log message
-------------------------------------------------------------------------

                 Key: QPID-2386
                 URL: https://issues.apache.org/jira/browse/QPID-2386
             Project: Qpid
          Issue Type: Bug
          Components: C++ Broker
         Environment: Red Hat Enterprise MRG 1.2
            Reporter: Armin Noll
            Priority: Minor


When the SASL authentication succeeds the broker then logs a message like the following:

2010-feb-03 15:28:45 info SASL: Authentication succeeded for: user@QPID

When the authentication fails it logs e.g.:

2010-feb-03 16:09:20 info SASL: Authentication failed: SASL(-13): authentication failure:
Password verification failed

It would be helpful if the log message in the latter case would also contain the user ID and
domain for which the authentication failed. It could look like
2010-feb-03 16:09:20 info SASL: Authentication failed for user@QPID: SASL(-13): authentication
failure: Password verification failed

I think this can easily be achieved by applying the following change to the module SASLAUTHENTICATOR.CPP:
OLD:
 } else {
	QPID_LOG(info, "SASL: Authentication failed: " << sasl_errdetail(sasl_conn));
	
	// TODO: Change to more specific exceptions, when they are
	// available
	switch (code) {

NEW:
 } else {
	QPID_LOG(info, "SASL: Authentication failed for " << const_cast<char*>(static_cast<const
char*>(uid)) << ": " << sasl_errdetail(sasl_conn));
	
	// TODO: Change to more specific exceptions, when they are
	// available
	switch (code) {


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message