qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Ritchie (JIRA)" <qpid-...@incubator.apache.org>
Subject [jira] Updated: (QPID-2490) TKTestListener's need to use Atomic counters.
Date Fri, 09 Apr 2010 10:33:51 GMT

     [ https://issues.apache.org/jira/browse/QPID-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Martin Ritchie updated QPID-2490:
---------------------------------

    Description: 
Currently the TKTestListener's use int to record results. In a multi-threaded test this is
not safe. They should be updated to Atomic values. So that Error+Failed+Pass === Total. Currently
discrepancies are occurring.

       if ("Error".equals(r.testState))
        {
            numError++;
        }
        else if ("Failure".equals(r.testState))
        {
            numFailed++;
        }
        else if ("Pass".equals(r.testState))
        {
            numPassed++;
        }

        totalTests++;


  was:
Currently the TKTestListener's use int to record results. In a multi-threaded test this is
not safe. They should be updated to Atomic values. So that Error+Failed+Pass === Total. Currently
discrepencies are occuring.

       if ("Error".equals(r.testState))
        {
            numError++;
        }
        else if ("Failure".equals(r.testState))
        {
            numFailed++;
        }
        else if ("Pass".equals(r.testState))
        {
            numPassed++;
        }

        totalTests++;



> TKTestListener's need to use Atomic counters.
> ---------------------------------------------
>
>                 Key: QPID-2490
>                 URL: https://issues.apache.org/jira/browse/QPID-2490
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Tests
>    Affects Versions: 0.5
>            Reporter: Martin Ritchie
>            Priority: Critical
>
> Currently the TKTestListener's use int to record results. In a multi-threaded test this
is not safe. They should be updated to Atomic values. So that Error+Failed+Pass === Total.
Currently discrepancies are occurring.
>        if ("Error".equals(r.testState))
>         {
>             numError++;
>         }
>         else if ("Failure".equals(r.testState))
>         {
>             numFailed++;
>         }
>         else if ("Pass".equals(r.testState))
>         {
>             numPassed++;
>         }
>         totalTests++;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message