qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway (JIRA)" <j...@apache.org>
Subject [jira] Commented: (QPID-2492) Changes to brokertest.py to better manage Windows brokers
Date Fri, 22 Oct 2010 15:18:20 GMT

    [ https://issues.apache.org/jira/browse/QPID-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923883#action_12923883

Alan Conway commented on QPID-2492:

I withdraw my objection to subprocess. Its already been used in some other test code, and
popen2 is deprecated in current python versions. I think we can skip tests if necessary on
old platforms that don't support it, or write a subprocess compatibility wrapper if we really
need to. That makes more sense then wrapping subprocess in a popen wrapper.

> Changes to brokertest.py to better manage Windows brokers
> ---------------------------------------------------------
>                 Key: QPID-2492
>                 URL: https://issues.apache.org/jira/browse/QPID-2492
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Python Test Suite
>    Affects Versions: 0.7
>            Reporter: Steve Huston
>         Attachments: brokertest.diff
> I've been developing tests for the persistence/store functionality using python/qpid/brokertest.py
and I've made some local changes to get this to work well on Windows. I'm a Python beginner,
and there may be better ways to do what I've done. Could someone please review the patch here
and let me know any suggestions?

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org

View raw message