qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Danushka Menikkumbura <danushka.menikkumb...@gmail.com>
Subject Re: Apply patches for QPID-2720 and QPID-2726
Date Mon, 04 Oct 2010 06:01:18 GMT
Hi Andrew,

I am shocked to see the patch for QPID-2720 is reverted in the current
trunk. Could you please check what has gone wrong?.

Thanks,
Danushka

On Mon, Oct 4, 2010 at 8:52 AM, Lahiru Gunathilake <glahiru@gmail.com>wrote:

> Robbie,
>
> Will you be able to look in to this please ?
>
> Regards
> Lahiru
>
> On Wed, Jul 14, 2010 at 12:26 PM, Danushka Menikkumbura <
> danushka.menikkumbura@gmail.com> wrote:
>
> > I see the patches for QPID-2726 have been applied by Robbie (rather his
> own
> > version of it though ;-)). Thanks Robbie!. Could someone (Robbie or
> > Andrew?)
> > please apply patches for QPID-2720 as well?. I think we have been
> dragging
> > this for too long.
> >
> > Thanks,
> > Danushka
> >
> > On Sun, Jul 11, 2010 at 12:46 AM, Danushka Menikkumbura <
> > danushka.menikkumbura@gmail.com> wrote:
> >
> > > Ah. Finally it gets there. What a relief!.
> > >
> > > Thanks a lot Robbie!.
> > >
> > > Danushka
> > >
> > >
> > > On Sat, Jul 10, 2010 at 9:46 PM, Robbie Gemmell <
> > robbie.gemmell@gmail.com>wrote:
> > >
> > >> Ah, now that wasn't mentioned before; slight difference between just
> not
> > >> being able to return plain text and not actually being able to return
> > >> anything at all :)
> > >>
> > >> Given that the alternatives involve a fair bit of reimplementation on
> > your
> > >> part and this is an area that should probably end up getting changed
> in
> > >> the
> > >> future anyway, I've just reverted the previous change and added
> > >> PlainPasswordCallback with similar functionality to the patch, you
> > should
> > >> be
> > >> able to use that in the same way.
> > >>
> > >> Robbie
> > >>
> > >> > -----Original Message-----
> > >> > From: Danushka Menikkumbura [mailto:danushka.menikkumbura@gmail.com
> ]
> > >> > Sent: 09 July 2010 20:00
> > >> > To: dev@qpid.apache.org
> > >> > Subject: Re: Apply patches for QPID-2720 and QPID-2726
> > >> >
> > >> > Hi Robbie,
> > >> >
> > >> > I of course get your point. But the problem I am having with this
> set
> > >> > up is
> > >> > that my password database can never return a password (yeah it
> sounds
> > >> > crazy
> > >> > ;-)). Basically my password database implementation talks to a user
> > >> > manager
> > >> > which can only say if a user is authenticated or not only. It never
> > >> > exposes
> > >> > the passwords. Thats why I wanted to have the authentication result
> in
> > >> > the
> > >> > password callback initially and then a new callback for
> authentication
> > >> > in
> > >> > the new model that you have been suggesting.
> > >> >
> > >> > Thanks,
> > >> > Danushka
> > >> >
> > >>
> > >>
> > >> ---------------------------------------------------------------------
> > >> Apache Qpid - AMQP Messaging Implementation
> > >> Project:      http://qpid.apache.org
> > >> Use/Interact: mailto:dev-subscribe@qpid.apache.org
> > >>
> > >>
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message