qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robbie Gemmell (JIRA)" <j...@apache.org>
Subject [jira] Commented: (QPID-2986) Segregate the XML Parsing into a utility class
Date Tue, 11 Jan 2011 14:58:47 GMT

    [ https://issues.apache.org/jira/browse/QPID-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980133#action_12980133
] 

Robbie Gemmell commented on QPID-2986:
--------------------------------------

Seems ok after a quick glance except for code style issues, ill take a closer look once those
are updated:

- No underscores on instance variables in QpidLog4JConfigurator (although, there isnt one
on the pre-existing domConfig variable either I see, oops)
- Use of  tab instead of spaces in various locations
- Various brace formats in XMLUtils/

> Segregate the XML Parsing into a utility class
> ----------------------------------------------
>
>                 Key: QPID-2986
>                 URL: https://issues.apache.org/jira/browse/QPID-2986
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>    Affects Versions: 0.8
>            Reporter: Sorin Suciu
>            Assignee: Robbie Gemmell
>            Priority: Minor
>             Fix For: 0.9
>
>         Attachments: qpid-2986.patch
>
>
> There is a slight xml parsing/validating code duplication QpidLog4JConfigurator and LoggingManagementMBean
and it would be useful to segregate the XML parsing as a utility class so we could reuse it
for XML configuration validation for example. The patch attached is an attempt to do so. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message