qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request: WIP: Enable -fvisibility=hidden, libraries export only public symbols
Date Tue, 22 Mar 2011 22:21:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/520/
-----------------------------------------------------------

(Updated 2011-03-22 15:21:38.905747)


Review request for qpid and Andrew Stitcher.


Summary (updated)
-------

WIP: Enable -fvisibility=hidden, libraries export only public symbols

Making progress. Working thru remaining link errors. 

- I seem to need class level EXTERN decls to resolve undefined vtable/typeinfo.
- need to ensure throwable types have extern typeinfo - class level EXTERN?


Diffs (updated)
-----

  trunk/qpid/cpp/configure.ac 1084053 
  trunk/qpid/cpp/include/qmf/ImportExport.h 1084053 
  trunk/qpid/cpp/include/qmf/engine/QmfEngineImportExport.h 1084053 
  trunk/qpid/cpp/include/qpid/CommonImportExport.h 1084053 
  trunk/qpid/cpp/include/qpid/Exception.h 1084053 
  trunk/qpid/cpp/include/qpid/ImportExportDefs.h PRE-CREATION 
  trunk/qpid/cpp/include/qpid/RangeSet.h 1084053 
  trunk/qpid/cpp/include/qpid/agent/QmfAgentImportExport.h 1084053 
  trunk/qpid/cpp/include/qpid/client/ClientImportExport.h 1084053 
  trunk/qpid/cpp/include/qpid/console/ConsoleImportExport.h 1084053 
  trunk/qpid/cpp/include/qpid/framing/SequenceNumber.h 1084053 
  trunk/qpid/cpp/include/qpid/framing/SequenceSet.h 1084053 
  trunk/qpid/cpp/include/qpid/messaging/ImportExport.h 1084053 
  trunk/qpid/cpp/include/qpid/sys/IOHandle.h 1084053 
  trunk/qpid/cpp/include/qpid/sys/posix/Mutex.h 1084053 
  trunk/qpid/cpp/include/qpid/sys/posix/PrivatePosix.h 1084053 
  trunk/qpid/cpp/include/qpid/types/ImportExport.h 1084053 
  trunk/qpid/cpp/src/Makefile.am 1084053 
  trunk/qpid/cpp/src/qmf.mk 1084053 
  trunk/qpid/cpp/src/qpid/broker/BrokerImportExport.h 1084053 
  trunk/qpid/cpp/src/qpid/sys/rdma/ImportExport.h PRE-CREATION 
  trunk/qpid/cpp/src/qpid/sys/rdma/RdmaIO.h 1084053 
  trunk/qpid/cpp/src/qpid/sys/rdma/rdma_wrap.h 1084053 

Diff: https://reviews.apache.org/r/520/diff


Testing
-------


Thanks,

Alan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message