qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Kennedy <andrewinternatio...@gmail.com>
Subject Re: NPE while processing the data block
Date Tue, 29 Mar 2011 23:22:54 GMT
On 29 March 2011 18:57, Robert Godfrey <rob.j.godfrey@gmail.com> wrote:
> On 29 March 2011 19:31, Rajika Kumarasiri <rajika@wso2.com> wrote:
>> I have a one last question on the patch. I have registered SSL protocol
>> handler as the last handler in the chain where you have registered as the
>> first ( see below for the diff). Please also refer [0]. And yes I tested
>> with following changes.
>>
>> Rajika
>>
>> @@ -363,7 +367,9 @@
>>          {
>>              if (_sslFactory != null)
>>              {
>> -
>> protocolSession.getFilterChain().addBefore("protocolFilter", "sslFilter",
>> +//
>> protocolSession.getFilterChain().addBefore("protocolFilter", "sslFilter",
>> +//                        new
>> SSLFilter(_sslFactory.buildServerContext()));
>> +                protocolSession.getFilterChain().addLast("sslFilter",
>>                          new SSLFilter(_sslFactory.buildServerContext()));
>>
>
> To be completely honest on debugging I found that there was only one filter
> in the chain at the point this code gets called...  I just thought that
> "first" for the SSL filter seemed more sensible that "last" (since you want
> SSL decrypt before anything else) and so that's what I tried... it worked...
> and I gave it no more thought :-)

Hi.

In my update to the networking stack I decided on adding SSL first as
well. There *are* other filters that may or may not be added, which
should come after this. For example, I experimented with logging and
executor filters, and there is the write and read buffer filtering
too. Also, Rob, I take it you'll remove the commented out lines of
code when this is checked in? Anyone interested in the history can
browse SVN if they want.

Andrew.
--
-- andrew d kennedy ? edinburgh : +44 7582 293 255

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message