qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Kennedy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3177) JMS Failover Not Working
Date Fri, 01 Apr 2011 20:47:05 GMT

    [ https://issues.apache.org/jira/browse/QPID-3177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014817#comment-13014817
] 

Andrew Kennedy commented on QPID-3177:
--------------------------------------

Yes, this is accidental. Thank's for spotting it. I had intended to refactor this more completely,
and part of that involved moving the connection resume to resubscribeSessions, which is called
indirectly. I have replaced this call.

> JMS Failover Not Working
> ------------------------
>
>                 Key: QPID-3177
>                 URL: https://issues.apache.org/jira/browse/QPID-3177
>             Project: Qpid
>          Issue Type: Bug
>    Affects Versions: 0.10
>            Reporter: Rajith Attapattu
>            Assignee: Rajith Attapattu
>            Priority: Blocker
>             Fix For: 0.10
>
>
> The JMS failover is not working due to a regression introduced in rev 1071631.
> More specifically the reason is the following line being removed.
> @@ -257,12 +256,14 @@
>          ConnectionClose close = exc.getClose();
>          if (close == null)
>          {
> +            _conn.getProtocolHandler().setFailoverLatch(new CountDownLatch(1));
> +            
>              try
>              {
>                  if (_conn.firePreFailover(false) && _conn.attemptReconnection())
>                  {
>                      _conn.failoverPrep();
> -                    _qpidConnection.resume();   ---- > This line is removed in this
comment.
> +                    _conn.resubscribeSessions();
>                      _conn.fireFailoverComplete();
>                      return;
>                  }
> On the surface this seems like a unintended omission. However I'd like to investigate
it further and find out if this was intentional.
> It if it was, then what was the reason behind it? 
> The obvious fix is to re-introduce this line. I have done so and preliminary tests indicates
that it will resolve the issue. I haven't seen any other issues.
> However I'd like to look at more information regarding the context of the above change
before making a final decision.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message