qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Wall (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3167) improve unit testing of SimpleAMQQueue#processQueue()
Date Fri, 01 Apr 2011 10:02:05 GMT

    [ https://issues.apache.org/jira/browse/QPID-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014500#comment-13014500
] 

Keith Wall commented on QPID-3167:
----------------------------------

No comments against your actual changes but:

1) I think we should take this opportunity to add some class javadoc to the newly extracted
QueueRunner.
2) In QueueRunner, _logger.error(e) is going to fail to log the underlying(s) in the broker
log.  This can make problem determination harder.  Would be better to use the two argument
form error(message,throwable)
3) I notice SubFlushRunner made its instance variables explicitly final.  I think QueueRunner
ought to have done the same.  I think the stricter form is preferable. 

I realise all of the above would have applied to code base prior to your change.



> improve unit testing of SimpleAMQQueue#processQueue()
> -----------------------------------------------------
>
>                 Key: QPID-3167
>                 URL: https://issues.apache.org/jira/browse/QPID-3167
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Tests
>            Reporter: Robbie Gemmell
>            Assignee: Keith Wall
>             Fix For: 0.11
>
>
> Improve unit testing of SimpleAMQQueue#processQueue(), in particular providing coverage
of the scenario encountered in the parent JIRA.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message