qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "rajith attapattu" <rajit...@gmail.com>
Subject Review Request: QPID-3254 - NPE when creating a durable subscriber using an addressing string configured in jndi.properties
Date Tue, 10 May 2011 03:38:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/706/
-----------------------------------------------------------

Review request for qpid.


Summary
-------

The attached patch adds code to resolve the address to determine the correct defualt for the
subject field and also to populate the legacy fields.
Also added null checks in both AMQAnyDestination and AMQTopic to prevent any NPE.


Diffs
-----

  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQAnyDestination.java
1099057 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java
1099288 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQTopic.java
1099057 

Diff: https://reviews.apache.org/r/706/diff


Testing
-------


Thanks,

rajith


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message