qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gordon Sim" <g...@redhat.com>
Subject Re: Review Request: Re-add explicit flushes to store when execution.sync and sync flag in message.transfer received.
Date Tue, 10 May 2011 08:35:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/701/#review653
-----------------------------------------------------------



/trunk/qpid/cpp/src/qpid/broker/SessionState.cpp
<https://reviews.apache.org/r/701/#comment1310>

    Maybe use swap() here?



/trunk/qpid/cpp/src/qpid/broker/SessionState.cpp
<https://reviews.apache.org/r/701/#comment1311>

    Looks good to me


- Gordon


On 2011-05-09 21:22:38, Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/701/
> -----------------------------------------------------------
> 
> (Updated 2011-05-09 21:22:38)
> 
> 
> Review request for qpid, Alan Conway, Gordon Sim, and Kim van der Riet.
> 
> 
> Summary
> -------
> 
> Broker now issues an explicit flush for each received message that has the sync flag
set in the message.transfer command.
> Broker also tracks all messages received that do _not_ have the sync flag set, and will
flush these messages on receipt of an execution.sync.
> 
> 
> This addresses bug QPID-3252.
>     https://issues.apache.org/jira/browse/QPID-3252
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1101206 
>   /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1101206 
> 
> Diff: https://reviews.apache.org/r/701/diff
> 
> 
> Testing
> -------
> 
> qpid unit & store unit
> 
> 
> Thanks,
> 
> Kenneth
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message