qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robbie Gemmell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3273) JMSDeliveryMode has to be used as a string in a selector
Date Thu, 16 Jun 2011 14:31:47 GMT

    [ https://issues.apache.org/jira/browse/QPID-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050449#comment-13050449
] 

Robbie Gemmell commented on QPID-3273:
--------------------------------------

Hi Rajith, I have a few comments on the patch:

The broker does not currently depend on the JMS specification jar, so it cant use the javax.jms.DeliveryMode
constants; there are a matching set of constants in the BasicContentHeaderProperties class,
if not others.

The [pre-existing] log statements will now continue to output the int value for the DeliveryMode
whilst the return value is updated to be a String, I think it should probably log the String
now, or both.

There should be a constant (one may or may not exist in the code base) for the PERSISTENT
and NON_PERSISTENT strings instead of sprinkling more literals around the code base for them.

The patch introduces a number of tabs instead of using spaces.

>  JMSDeliveryMode has to be used as a string in a selector
> ---------------------------------------------------------
>
>                 Key: QPID-3273
>                 URL: https://issues.apache.org/jira/browse/QPID-3273
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.6, 0.8, 0.10
>            Reporter: Rajith Attapattu
>            Assignee: Rajith Attapattu
>            Priority: Minor
>             Fix For: 0.11
>
>         Attachments: QPID-3273.patch
>
>
> Section 3.8.13 of the JMS spec says that JMSDeliveryMode has to be used as a string in
a selector (i.e. JMSDeliveryMode = 'PERSISTENT'). 
> But Qpid only supports it as an integer (i.e JMSDeliveryMode = 2).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message