qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request: QPID-3280: Fixed extra failover update messages on brokers joining the cluster.
Date Thu, 02 Jun 2011 20:28:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/791/
-----------------------------------------------------------

(Updated 2011-06-02 20:28:13.387392)


Review request for qpid, Andrew Stitcher, Alan Conway, Gordon Sim, and Andy Goldstein.


Changes
-------

Fixed a bug that caused inconsistencies in the number of messages on failover-update queues.

Still intermittently failing the ttl_failover_test, with an inconsistency in the number of
messages on queue "q". It appears that in some cases messages are being expired by the queue
cleaner on one broker but by consume on another. I'm chasing this down, if anyone has any
insights let me know.


Summary (updated)
-------

QPID-3280: Fixed extra failover update messages on brokers joining the cluster.


QPID-3280: When sending a large number of messages with nonzero TTLs to a cluster, overall
message throughput drops by around 20-30% compared to messages with TTL 0.

Replaced the complicated message expirly logic in the cluster with a simpler "cluster clock"
for expiry of messages with TTL.


Diffs (updated)
-----

  /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1128070 
  /trunk/qpid/cpp/src/qpid/broker/ExpiryPolicy.h 1128070 
  /trunk/qpid/cpp/src/qpid/broker/ExpiryPolicy.cpp 1128070 
  /trunk/qpid/cpp/src/qpid/broker/Message.cpp 1128070 
  /trunk/qpid/cpp/src/qpid/broker/QueueCleaner.h 1128070 
  /trunk/qpid/cpp/src/qpid/broker/QueueCleaner.cpp 1128070 
  /trunk/qpid/cpp/src/qpid/cluster/Cluster.h 1128070 
  /trunk/qpid/cpp/src/qpid/cluster/Cluster.cpp 1128070 
  /trunk/qpid/cpp/src/qpid/cluster/ClusterPlugin.cpp 1128070 
  /trunk/qpid/cpp/src/qpid/cluster/ClusterSettings.h 1128070 
  /trunk/qpid/cpp/src/qpid/cluster/ClusterTimer.cpp 1128070 
  /trunk/qpid/cpp/src/qpid/cluster/Connection.h 1128070 
  /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1128070 
  /trunk/qpid/cpp/src/qpid/cluster/ExpiryPolicy.h 1128070 
  /trunk/qpid/cpp/src/qpid/cluster/ExpiryPolicy.cpp 1128070 
  /trunk/qpid/cpp/src/qpid/cluster/FailoverExchange.h 1128070 
  /trunk/qpid/cpp/src/qpid/cluster/FailoverExchange.cpp 1128070 
  /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1128070 
  /trunk/qpid/cpp/src/qpid/sys/Timer.h 1128070 
  /trunk/qpid/cpp/src/qpid/sys/Timer.cpp 1128070 
  /trunk/qpid/cpp/src/tests/QueueTest.cpp 1128070 
  /trunk/qpid/cpp/src/tests/cluster_test_logs.py 1128070 
  /trunk/qpid/cpp/src/tests/cluster_tests.py 1128070 
  /trunk/qpid/cpp/xml/cluster.xml 1128070 

Diff: https://reviews.apache.org/r/791/diff


Testing
-------


Thanks,

Alan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message